Skip to content

feat: batch create ddl#3194

Merged
MichaelScofield merged 3 commits intoGreptimeTeam:mainfrom
fengjiachun:feat/batch-ddl
Jan 26, 2024
Merged

feat: batch create ddl#3194
MichaelScofield merged 3 commits intoGreptimeTeam:mainfrom
fengjiachun:feat/batch-ddl

Conversation

@fengjiachun
Copy link
Copy Markdown
Collaborator

@fengjiachun fengjiachun commented Jan 18, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Batch create logical tables with procedure

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions Bot added docs-not-required This change does not impact docs. Size: L labels Jan 18, 2024
@fengjiachun fengjiachun changed the title feat: batch ddl feat: batch create ddl Jan 18, 2024
@fengjiachun fengjiachun marked this pull request as draft January 18, 2024 12:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 18, 2024

Codecov Report

Attention: 413 lines in your changes are missing coverage. Please review.

Comparison is base (8bade8f) 85.79% compared to head (58be92f) 85.16%.

❗ Current head 58be92f differs from pull request most recent head 220a70a. Consider uploading reports for the commit 220a70a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3194      +/-   ##
==========================================
- Coverage   85.79%   85.16%   -0.64%     
==========================================
  Files         848      850       +2     
  Lines      139148   139916     +768     
==========================================
- Hits       119388   119155     -233     
- Misses      19760    20761    +1001     

@github-actions github-actions Bot added Size: XL and removed Size: L labels Jan 18, 2024
@fengjiachun fengjiachun marked this pull request as ready for review January 19, 2024 12:11
Comment thread src/common/meta/src/ddl_manager.rs Outdated
@fengjiachun fengjiachun requested review from MichaelScofield, WenyXu and waynexia and removed request for MichaelScofield and waynexia January 19, 2024 12:14
Comment thread src/common/meta/src/ddl/create_tables.rs Outdated
@fengjiachun fengjiachun force-pushed the feat/batch-ddl branch 2 times, most recently from c2bb5ab to 01785fe Compare January 19, 2024 14:13
Comment thread Cargo.toml Outdated
Copy link
Copy Markdown
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to take a look the rest later...

Comment thread src/operator/src/statement/ddl.rs Outdated
Comment thread src/common/meta/src/key/table_name.rs
Comment thread src/common/meta/src/key.rs
Comment thread src/common/meta/src/key.rs
Comment thread src/common/meta/src/key.rs
Comment thread src/common/meta/src/ddl/table_meta.rs Outdated
Comment thread src/common/meta/src/ddl/create_tables.rs
Comment thread src/common/meta/src/ddl/create_tables.rs
Comment thread src/common/meta/src/ddl/create_tables.rs Outdated
Comment thread src/common/meta/src/ddl/create_tables.rs Outdated
Comment thread src/common/meta/src/ddl/create_tables.rs Outdated
Comment thread src/common/meta/src/ddl/create_tables.rs Outdated
@fengjiachun
Copy link
Copy Markdown
Collaborator Author

@WenyXu PTAL

Copy link
Copy Markdown
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun
Copy link
Copy Markdown
Collaborator Author

@MichaelScofield PTAL

Comment thread src/common/meta/src/key.rs Outdated
Comment thread src/common/meta/src/ddl/create_logical_tables.rs Outdated
Comment thread src/common/meta/src/ddl_manager.rs Outdated
Comment thread src/common/meta/src/error.rs Outdated
Comment thread src/common/meta/src/rpc/ddl.rs Outdated
Comment thread src/common/meta/src/rpc/ddl.rs Outdated
@fengjiachun fengjiachun force-pushed the feat/batch-ddl branch 4 times, most recently from 2956844 to 58be92f Compare January 25, 2024 15:26
chore: by comment

chore: remove wal_options

chore: create logical tables lock key

feat: get metadata in procedure
@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 26, 2024
Merged via the queue into GreptimeTeam:main with commit 1fab7ab Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants