Skip to content

feat: read metadata from write cache#3224

Merged
evenyag merged 6 commits into
GreptimeTeam:mainfrom
QuenKar:feat/read-metadata-from-cache
Jan 25, 2024
Merged

feat: read metadata from write cache#3224
evenyag merged 6 commits into
GreptimeTeam:mainfrom
QuenKar:feat/read-metadata-from-cache

Conversation

@QuenKar
Copy link
Copy Markdown
Contributor

@QuenKar QuenKar commented Jan 23, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • read parquet metadata from write cache.
  • refactor some test code.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2965

@github-actions github-actions Bot added docs-not-required This change does not impact docs. Size: M labels Jan 23, 2024
@QuenKar QuenKar marked this pull request as ready for review January 24, 2024 03:51
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (966875e) 85.80% compared to head (be091a2) 85.35%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3224      +/-   ##
==========================================
- Coverage   85.80%   85.35%   -0.46%     
==========================================
  Files         840      848       +8     
  Lines      137539   139142    +1603     
==========================================
+ Hits       118013   118759     +746     
- Misses      19526    20383     +857     

@QuenKar QuenKar requested a review from evenyag January 24, 2024 06:10
@QuenKar QuenKar marked this pull request as draft January 24, 2024 06:24
@QuenKar QuenKar marked this pull request as ready for review January 24, 2024 06:48
Comment thread src/mito2/src/cache.rs Outdated
Comment thread src/mito2/src/cache/file_cache.rs Outdated
Comment thread src/mito2/src/cache/file_cache.rs
Comment thread src/mito2/src/sst/parquet/reader.rs Outdated
@QuenKar QuenKar requested a review from zhongzc January 25, 2024 08:19
Comment thread src/mito2/src/cache.rs
Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Jan 25, 2024
Merged via the queue into GreptimeTeam:main with commit 6c2f0c9 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants