refactor: passing QueryContext to RegionServer#3829
Merged
killme2008 merged 6 commits intoGreptimeTeam:mainfrom May 7, 2024
Merged
refactor: passing QueryContext to RegionServer#3829killme2008 merged 6 commits intoGreptimeTeam:mainfrom
killme2008 merged 6 commits intoGreptimeTeam:mainfrom
Conversation
bfb1840 to
a8eff60
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
==========================================
- Coverage 85.61% 85.29% -0.33%
==========================================
Files 952 952
Lines 163062 163079 +17
==========================================
- Hits 139605 139097 -508
- Misses 23457 23982 +525 |
a8eff60 to
57142a7
Compare
evenyag
approved these changes
May 2, 2024
e0a2535 to
9043dd8
Compare
Collaborator
|
Hi @Kelvinyu1117 , there are some conflicts need to be resolved. |
Member
|
Good job! Please resolve the conflicts, then we can merge the PR. @Kelvinyu1117 |
0c332cb to
b8f9b4b
Compare
Contributor
Author
Should be fixed. |
Member
Hi @Kelvinyu1117 , The coverage tests failed( |
b8f9b4b to
b901f82
Compare
killme2008
reviewed
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #3752
What's changed and what's your intention?
Allow passing the query context to the region server.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist