Skip to content

feat: metasrvs nodeinfo#3873

Merged
fengjiachun merged 4 commits intoGreptimeTeam:mainfrom
fengjiachun:feat/metasrv-nodeinfo
May 7, 2024
Merged

feat: metasrvs nodeinfo#3873
fengjiachun merged 4 commits intoGreptimeTeam:mainfrom
fengjiachun:feat/metasrv-nodeinfo

Conversation

@fengjiachun
Copy link
Copy Markdown
Collaborator

@fengjiachun fengjiachun commented May 7, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Allow to get metsrvs' node info (version and git_commit).

proto: GreptimeTeam/greptime-proto#163

Closes: #3843

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@fengjiachun fengjiachun requested review from a team and MichaelScofield as code owners May 7, 2024 08:19
@github-actions github-actions Bot added the docs-not-required This change does not impact docs. label May 7, 2024
@fengjiachun fengjiachun requested a review from killme2008 May 7, 2024 08:19
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 85.29%. Comparing base (154f561) to head (902c072).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3873      +/-   ##
==========================================
- Coverage   85.60%   85.29%   -0.31%     
==========================================
  Files         952      952              
  Lines      163079   163290     +211     
==========================================
- Hits       139596   139283     -313     
- Misses      23483    24007     +524

@fengjiachun fengjiachun mentioned this pull request May 7, 2024
Closed
fengjiachun
fengjiachun commented May 7, 2024
View reviewed changes
Comment thread Cargo.toml Outdated
killme2008
killme2008 approved these changes May 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/meta-srv/src/election/etcd.rs Outdated
@MichaelScofield MichaelScofield enabled auto-merge May 7, 2024 10:53
@MichaelScofield MichaelScofield added this pull request to the merge queue May 7, 2024
@fengjiachun fengjiachun removed this pull request from the merge queue due to a manual request May 7, 2024
@fengjiachun fengjiachun enabled auto-merge May 7, 2024 11:05
@fengjiachun fengjiachun added this pull request to the merge queue May 7, 2024
Merged via the queue into GreptimeTeam:main with commit 6e1cc1d May 7, 2024
@fengjiachun fengjiachun deleted the feat/metasrv-nodeinfo branch May 7, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@killme2008 killme2008 killme2008 approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

Assignees

No one assigned

Labels

docs-not-required This change does not impact docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Retrieve the metasrv node info in meta-client

3 participants

@fengjiachun @killme2008 @MichaelScofield