feat: alter fulltext options by CookiePieWw · Pull Request #4952 · GreptimeTeam/greptimedb

CookiePieWw · 2024-11-06T11:31:39Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As in #4637, support alter fulltext options for column:
ALTER TABLE monitor SET COLUMN <column_name> FULLTEXT WITH(analyzer = 'Chinese', case_sensitive = 'false');

Currently we only support to change the fulltext option when:

Enable to disable
Disable to enable
Disable to disable (no effect actually)

Big thanks to @irenjj for his previous pr #4637 which helps a lot.

Checklist

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.

coderabbitai · 2024-11-06T11:31:45Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-11-07T04:58:39Z

Codecov Report

Attention: Patch coverage is 84.57350% with 85 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (6248a6c) to head (6678fa5).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4952      +/-   ##
==========================================
- Coverage   84.06%   83.84%   -0.23%     
==========================================
  Files        1143     1143              
  Lines      212022   212512     +490     
==========================================
- Hits       178242   178174      -68     
- Misses      33780    34338     +558

WenyXu

Rest LGTM

Co-Authored-By: irenjj <renj.jiang@gmail.com>

fengjiachun

Rest LGTM

* feat(WIP): alter fulltext index Co-Authored-By: irenjj <renj.jiang@gmail.com> * feat: alter column fulltext option Co-Authored-By: irenjj <renj.jiang@gmail.com> * chore: fmt * test: add unit and integration tests Co-Authored-By: irenjj <renj.jiang@gmail.com> * test: update sqlness test * chore: new line * chore: lock file update * chore: apply review comments * test: update sqlness test * test: update sqlness test * fix: convert * chore: apply review comments * fix: toml fmt * fix: tests * test: add test for mito * chore: error message * fix: test * fix: test * fix: wrong comment * chore: change proto rev * chore: apply review comments * chore: apply review comments * chore: fmt --------- Co-authored-by: irenjj <renj.jiang@gmail.com>

CookiePieWw changed the title ~~feat: alter fulltext options~~ feat(WIP): alter fulltext options Nov 6, 2024

github-actions Bot added the docs-not-required This change does not impact docs. label Nov 6, 2024

CookiePieWw force-pushed the alter_fulltext branch from 7cc1882 to 77852d1 Compare November 7, 2024 04:11

CookiePieWw changed the title ~~feat(WIP): alter fulltext options~~ feat: alter fulltext options Nov 7, 2024

CookiePieWw force-pushed the alter_fulltext branch from 5298fde to 63479f6 Compare November 7, 2024 04:40

CookiePieWw marked this pull request as ready for review November 7, 2024 04:40

CookiePieWw requested review from a team, MichaelScofield, evenyag and v0y4g3r as code owners November 7, 2024 04:40

CookiePieWw removed request for MichaelScofield, evenyag and v0y4g3r November 7, 2024 04:44

CookiePieWw mentioned this pull request Nov 7, 2024

feat: alter fulltext index GreptimeTeam/greptime-proto#196

Merged

2 tasks

WenyXu reviewed Nov 7, 2024

View reviewed changes

Comment thread src/api/src/v1/column_def.rs

Comment thread src/sql/src/parsers/alter_parser.rs

CookiePieWw mentioned this pull request Nov 7, 2024

docs: update alter column fulltext options GreptimeTeam/docs#1271

Merged

3 tasks

WenyXu requested a review from fengjiachun November 7, 2024 08:57

WenyXu reviewed Nov 8, 2024

View reviewed changes

Comment thread Cargo.toml Outdated

WenyXu reviewed Nov 8, 2024

View reviewed changes

Comment thread src/operator/src/expr_factory.rs Outdated

Comment thread src/store-api/src/metadata.rs Outdated

Comment thread src/table/src/error.rs

Comment thread src/store-api/src/metadata.rs Outdated

Comment thread src/store-api/src/metadata.rs Outdated

WenyXu reviewed Nov 8, 2024

View reviewed changes

Comment thread src/store-api/src/metadata.rs Outdated

CookiePieWw requested a review from waynexia as a code owner November 8, 2024 08:52

fengjiachun requested a review from zhongzc November 8, 2024 09:00

WenyXu approved these changes Nov 11, 2024

View reviewed changes

Comment thread src/table/src/metadata.rs Outdated

Comment thread src/operator/src/expr_factory.rs Outdated

Comment thread src/mito2/src/engine/alter_test.rs Outdated

Comment thread src/mito2/src/engine/alter_test.rs

fengjiachun reviewed Nov 11, 2024

View reviewed changes

CookiePieWw and others added 4 commits November 11, 2024 18:24

feat(WIP): alter fulltext index

f39428d

Co-Authored-By: irenjj <renj.jiang@gmail.com>

feat: alter column fulltext option

a2b3b8b

Co-Authored-By: irenjj <renj.jiang@gmail.com>

chore: fmt

845398e

test: add unit and integration tests

3e3fc5f

Co-Authored-By: irenjj <renj.jiang@gmail.com>

CookiePieWw added 13 commits November 11, 2024 18:24

fix: convert

e5af8d9

chore: apply review comments

3a296eb

fix: toml fmt

ff13512

fix: tests

03e671d

test: add test for mito

1d9bf9c

chore: error message

56e9449

fix: test

fe9b497

fix: test

b64da2f

fix: wrong comment

b1a566b

chore: change proto rev

e351be5

chore: apply review comments

71456f9

chore: apply review comments

65b87ee

chore: fmt

6678fa5

CookiePieWw force-pushed the alter_fulltext branch from d267348 to 6678fa5 Compare November 11, 2024 10:33

fengjiachun reviewed Nov 11, 2024

View reviewed changes

Comment thread src/sql/src/parsers/alter_parser.rs

fengjiachun approved these changes Nov 11, 2024

View reviewed changes

github-actions Bot added docs-required This change requires docs update. docs-not-required This change does not impact docs. and removed docs-not-required This change does not impact docs. docs-required This change requires docs update. labels Nov 12, 2024

WenyXu mentioned this pull request Nov 12, 2024

Add docs for altering fulltext options GreptimeTeam/docs#1277

Closed

WenyXu added this pull request to the merge queue Nov 12, 2024

WenyXu mentioned this pull request Nov 12, 2024

feat: Alter column fulltext option #4637

Closed

3 tasks

Merged via the queue into GreptimeTeam:main with commit 84aa5b7 Nov 12, 2024

CookiePieWw mentioned this pull request Nov 13, 2024

refactor: use UNSET instead of enable #4983

Merged

3 tasks

CookiePieWw deleted the alter_fulltext branch November 25, 2024 07:39

lyang24 mentioned this pull request Nov 28, 2024

Alter inverted index #5059

Closed

CookiePieWw mentioned this pull request Dec 9, 2024

discussion for set fulltext options method #5116

Closed

Conversation

CookiePieWw commented Nov 6, 2024 • edited by WenyXu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Checklist

Uh oh!

coderabbitai Bot commented Nov 6, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

codecov Bot commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WenyXu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengjiachun left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CookiePieWw commented Nov 6, 2024 •

edited by WenyXu

Loading

codecov Bot commented Nov 7, 2024 •

edited

Loading