fix: store flow query ctx on creation#5963
Merged
discord9 merged 6 commits intoGreptimeTeam:mainfrom Apr 23, 2025
Merged
Conversation
discord9
requested review from
a team,
MichaelScofield,
waynexia and
zhongzc
as code owners
discord9
changed the title
WenyXu
approved these changes
Apr 23, 2025
discord9
added a commit
to discord9/greptimedb
that referenced
this pull request
Apr 23, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
* feat: use flow batching engine broken: try using logical plan fix: use dummy catalog for logical plan fix: insert plan exec&sqlness grpc addr feat: use frontend instance in flownode in standalone feat: flow type in metasrv&fix: flush flow out of sync& column name alias tests: sqlness update tests: sqlness flow rebuild udpate chore: per review refactor: keep chnl mgr refactor: use catalog mgr for get table tests: use valid sql fix: add more check refactor: put flow type determine to frontend * chore: update proto * chore: update proto to main branch * fix: add locks for create/drop flow&docs: update docs * feat: flush_flow flush all ranges now * test: add align time window test * docs: explain `nodeid` use in check task * refactor: AddAutoColumnRewriter check for Projection * refactor: per review * fix: query without time window also clean dirty time window * chore: better logging * chore: add comments per review * refactor: per review * chore: per review * chore: per review rename args * refactor: per review partially * chore: update docs * chore: use better error variant * chore: better error variant * refactor: rename FlowWorkerManager to FlowStreamingEngine * rename again * refactor: per review * chore: rebase after #5963 merged * refactor: rename all flow_worker_manager occurs * docs: rm resolved TODO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5959
What's changed and what's your intention?
flow need to parse
raw_sql,hence ifschema!=public, on recover flows it will failed to find correct table ifraw_sqlref to tables not inpublicschema, fix is to store schema for flows, and when recover flows using ithence when recovering flow using
raw_sql, need the sameQueryContextso that the sql can be parsed as the same logical plan#[serde(default)])PR Checklist
Please convert it to a draft if some of the following conditions are not met.