feat: track flow source tables for TQL and info schema#7697
feat: track flow source tables for TQL and info schema#7697waynexia merged 4 commits intoGreptimeTeam:mainfrom
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Summary of ChangesHello @waynexia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the capability to track and expose the source tables used within TQL (Time-series Query Language) flow tasks. By integrating a PromQL parser, the system can now accurately identify the underlying tables referenced in TQL expressions, making this crucial metadata available in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@codex review |
There was a problem hiding this comment.
Code Review
This pull request introduces a great feature to track source tables for TQL flows. The implementation correctly parses PromQL queries to extract metric names, which correspond to table names, and also handles schema/database overrides via labels. The refactoring in information_schema/flows.rs to improve the efficiency of fetching source table names is also a good improvement.
My review includes a couple of suggestions to make the TQL parsing logic more robust and predictable, especially regarding how different types of matchers for __name__ are handled and the precedence between __schema__ and __database__ labels.
Overall, this is a solid contribution. Please take a look at my comments.
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Fill the
source_tablecolumn for TQL flow tasks in batching modePR Checklist
Please convert it to a draft if some of the following conditions are not met.