feat: replace shadow-rs with self-maintained version info#7782
feat: replace shadow-rs with self-maintained version info#7782waynexia merged 5 commits intoGreptimeTeam:mainfrom
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's version information handling. The primary goal was to enhance build reproducibility and efficiency by replacing the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request replaces the shadow-rs crate with a self-maintained build script to generate version information. This is a good move to achieve reproducible builds and reduce dependencies. The implementation in build.rs is well-structured, particularly the logic for re-running the build script. I have a couple of suggestions to improve robustness and clarity.
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Shadow-rs watches itself and always triggers rebuild (no reproducible build). This patch removes shadow-rs and uses a self-maintained version info instead. This also removes the source-time field from version info, which seems unnecessary to me as we always include a commit hash
PR Checklist
Please convert it to a draft if some of the following conditions are not met.