feat: add incremental read context and scan boundaries#7848
Conversation
Signed-off-by: discord9 <discord9@163.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the foundational components for implementing sequence-based incremental reads within the system. It modifies core data structures like Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively lays the groundwork for sequence-based incremental reads by introducing necessary fields to the query context and scan requests. The changes are well-structured, propagating the new context through different layers of the system, and include comprehensive tests for the new parsing logic. My feedback focuses on improving documentation for public data structures and refining some data conversion implementations for better conciseness and robustness.
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add the foundational query context and scan request fields for
sequence-based incremental reads.
This wires flow incremental extensions, snapshot sequence transport,
and scan boundary fields without bringing in Flow state-machine or
rewrite POC logic yet.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.