Skip to content

chore: remove unused rexpect dev-dependency#7865

Merged
sunng87 merged 2 commits intoGreptimeTeam:mainfrom
fengys1996:chore/remove-rexpect-dev-dependency
Mar 26, 2026
Merged

chore: remove unused rexpect dev-dependency#7865
sunng87 merged 2 commits intoGreptimeTeam:mainfrom
fengys1996:chore/remove-rexpect-dev-dependency

Conversation

@fengys1996
Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This pr remove unused rexpect dev-dependency.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@fengys1996 fengys1996 requested a review from a team as a code owner March 26, 2026 02:31
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on optimizing the project's dependency tree by eliminating an identified unused development dependency, rexpect. This cleanup helps reduce build times, decrease the overall project footprint, and maintain a leaner, more efficient dependency graph.

Highlights

  • Dependency Removal: The unused rexpect development dependency has been completely removed from the project's dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the rexpect crate and its associated dependencies, including comma, nix (version 0.25.1), and memoffset (version 0.6.5), from the project. This is reflected in both src/cmd/Cargo.toml, where rexpect is removed as a dev-dependency, and Cargo.lock, which updates to remove the package definitions and adjust dependency references accordingly. There is no feedback to provide.

Copy link
Copy Markdown
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 enabled auto-merge March 26, 2026 03:11
@sunng87 sunng87 added this pull request to the merge queue Mar 26, 2026
Merged via the queue into GreptimeTeam:main with commit 8d40b12 Mar 26, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants