Skip to content

fix: correct app-name for dashboard#7884

Merged
evenyag merged 1 commit intoGreptimeTeam:mainfrom
sunng87:fix/app-name-cast
Mar 30, 2026
Merged

fix: correct app-name for dashboard#7884
evenyag merged 1 commit intoGreptimeTeam:mainfrom
sunng87:fix/app-name-cast

Conversation

@sunng87
Copy link
Copy Markdown
Member

@sunng87 sunng87 commented Mar 30, 2026

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Correct app name change.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@sunng87 sunng87 requested a review from a team as a code owner March 30, 2026 07:45
@sunng87 sunng87 requested a review from evenyag March 30, 2026 07:45
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 30, 2026
@sunng87 sunng87 requested a review from shuiyisong March 30, 2026 07:45
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the const_format dependency from the src/cmd crate. The APP_NAME constants in the cli, datanode, flownode, frontend, metasrv, and standalone modules have been updated to use static string literals instead of dynamic concatenation. I have no feedback to provide.

@evenyag evenyag enabled auto-merge March 30, 2026 07:52
@evenyag evenyag added this pull request to the merge queue Mar 30, 2026
Merged via the queue into GreptimeTeam:main with commit 6bd14aa Mar 30, 2026
48 checks passed
sunng87 added a commit to sunng87/greptimedb that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants