chore: remove unused deps using udeps#7906
Merged
sunng87 merged 2 commits intoGreptimeTeam:mainfrom Apr 2, 2026
Merged
Conversation
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request performs a large-scale cleanup of Cargo dependencies across multiple crates, removing unused dependencies and reclassifying others. However, the review highlights potential issues with these changes: removing foundational dependencies like common-error and common-macro from common-base may break downstream crates that rely on exported macros, while moving datafusion-orc and common-recordbatch to dev-dependencies in their respective crates could cause compilation failures for library code that requires these dependencies for core functionality.
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
fengys1996
approved these changes
Apr 2, 2026
sunng87
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As the title suggests.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.