Skip to content

chore: remove unused deps using udeps#7906

Merged
sunng87 merged 2 commits intoGreptimeTeam:mainfrom
shuiyisong:chore/udeps
Apr 2, 2026
Merged

chore: remove unused deps using udeps#7906
sunng87 merged 2 commits intoGreptimeTeam:mainfrom
shuiyisong:chore/udeps

Conversation

@shuiyisong
Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title suggests.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

Signed-off-by: shuiyisong <xixing.sys@gmail.com>
@github-actions github-actions bot added size/XS docs-not-required This change does not impact docs. labels Apr 2, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a large-scale cleanup of Cargo dependencies across multiple crates, removing unused dependencies and reclassifying others. However, the review highlights potential issues with these changes: removing foundational dependencies like common-error and common-macro from common-base may break downstream crates that rely on exported macros, while moving datafusion-orc and common-recordbatch to dev-dependencies in their respective crates could cause compilation failures for library code that requires these dependencies for core functionality.

Signed-off-by: shuiyisong <xixing.sys@gmail.com>
@sunng87 sunng87 enabled auto-merge April 2, 2026 06:48
@sunng87 sunng87 added this pull request to the merge queue Apr 2, 2026
Merged via the queue into GreptimeTeam:main with commit ba32c5f Apr 2, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants