feat: impl RangeArray based on DictionaryArray#796
Merged
v0y4g3r merged 8 commits intoGreptimeTeam:developfrom Jan 3, 2023
Merged
feat: impl RangeArray based on DictionaryArray#796v0y4g3r merged 8 commits intoGreptimeTeam:developfrom
v0y4g3r merged 8 commits intoGreptimeTeam:developfrom
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #796 +/- ##
===========================================
- Coverage 85.34% 85.15% -0.19%
===========================================
Files 418 418
Lines 54311 55157 +846
===========================================
+ Hits 46351 46970 +619
- Misses 7960 8187 +227
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evenyag
reviewed
Dec 29, 2022
evenyag
reviewed
Jan 3, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
v0y4g3r
reviewed
Jan 3, 2023
Co-authored-by: Lei, HUANG <6406592+v0y4g3r@users.noreply.github.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: impl RangeArray based on DictionaryArray Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * fix clippys Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * apply review suggs * fix typo Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * update license header Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * Apply suggestions from code review Co-authored-by: Lei, HUANG <6406592+v0y4g3r@users.noreply.github.com> * update doc to change i32 to u32 Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Co-authored-by: Lei, HUANG <6406592+v0y4g3r@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruihang Xia waynestxia@gmail.com
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Implement the
RangeArrayas described in RFC: https://github.com/GreptimeTeam/greptimedb/blob/develop/docs/rfcs/2022-12-20-promql-in-rust/rfc.md#data-modelIt's a basic type of the PromQL execute extension. To represent
MatrixorRangeVectorin Prometheus. See the document ofRangeArraystruct for a detailed explaination.Checklist
Refer to a related PR or issue link (optional)
#596