Skip to content

fix: license header#815

Merged
evenyag merged 1 commit intoGreptimeTeam:developfrom
v0y4g3r:fix/license-header
Jan 3, 2023
Merged

fix: license header#815
evenyag merged 1 commit intoGreptimeTeam:developfrom
v0y4g3r:fix/license-header

Conversation

@v0y4g3r
Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r commented Jan 3, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fix indent and year issue in license header.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

fix #814

@v0y4g3r v0y4g3r marked this pull request as ready for review January 3, 2023 06:24
@v0y4g3r v0y4g3r requested review from evenyag and waynexia January 3, 2023 06:26
Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be tedious for this time 🤪

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@179ff72). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             develop     #815   +/-   ##
==========================================
  Coverage           ?   85.26%           
==========================================
  Files              ?      416           
  Lines              ?    54321           
  Branches           ?        0           
==========================================
  Hits               ?    46315           
  Misses             ?     8006           
  Partials           ?        0           
Flag Coverage Δ
rust 85.26% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/api/src/error.rs 7.14% <ø> (ø)
src/api/src/helper.rs 91.01% <ø> (ø)
src/api/src/result.rs 100.00% <ø> (ø)
src/api/src/serde.rs 100.00% <ø> (ø)
src/api/src/v1/column_def.rs 100.00% <ø> (ø)
src/api/src/v1/meta.rs 78.81% <ø> (ø)
src/catalog/src/error.rs 82.60% <ø> (ø)
src/catalog/src/helper.rs 85.92% <ø> (ø)
src/catalog/src/local/manager.rs 63.20% <ø> (ø)
src/catalog/src/local/memory.rs 80.89% <ø> (ø)
... and 248 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I need this to make my PR pass the CI jobs 😄

@evenyag evenyag merged commit 8ffc078 into GreptimeTeam:develop Jan 3, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

license-header-check failed

3 participants