Skip to content

feat: endpoint and region config for s3 storage#820

Merged
killme2008 merged 2 commits intoGreptimeTeam:developfrom
killme2008:feature/add-s3-config
Jan 4, 2023
Merged

feat: endpoint and region config for s3 storage#820
killme2008 merged 2 commits intoGreptimeTeam:developfrom
killme2008:feature/add-s3-config

Conversation

@killme2008
Copy link
Copy Markdown
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Main changes:

  • Adds #[serde(default)] attribute to all config options.
  • Adds region and endpoint config for s3 storage.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@killme2008 killme2008 marked this pull request as ready for review January 3, 2023 12:45
@killme2008 killme2008 requested review from MichaelScofield, fengjiachun, fengys1996, v0y4g3r and waynexia and removed request for fengjiachun January 3, 2023 12:47
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 3, 2023

Codecov Report

Merging #820 (f70c0fc) into develop (041cd42) will decrease coverage by 0.10%.
The diff coverage is 40.47%.

@@             Coverage Diff             @@
##           develop     #820      +/-   ##
===========================================
- Coverage    85.27%   85.17%   -0.11%     
===========================================
  Files          418      418              
  Lines        55224    55258      +34     
===========================================
- Hits         47094    47065      -29     
- Misses        8130     8193      +63     
Flag Coverage Δ
rust 85.17% <40.47%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd/src/standalone.rs 56.30% <ø> (+6.75%) ⬆️
src/datanode/src/datanode.rs 47.72% <ø> (ø)
src/datanode/src/instance.rs 29.89% <0.00%> (-13.68%) ⬇️
src/frontend/src/frontend.rs 38.88% <ø> (ø)
src/meta-srv/src/metasrv.rs 70.40% <ø> (ø)
tests-integration/src/test_util.rs 86.89% <0.00%> (-12.62%) ⬇️
src/cmd/src/toml_loader.rs 100.00% <100.00%> (ø)
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 7762873 into GreptimeTeam:develop Jan 4, 2023
@killme2008 killme2008 deleted the feature/add-s3-config branch January 4, 2023 03:24
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: adds serde default attribute to options

* feat: adds endpoint and region for s3 config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants