Skip to content

feat: Impl Insert functionality of Arrow Flight service for Frontend Instance#821

Merged
v0y4g3r merged 5 commits intoGreptimeTeam:developfrom
MichaelScofield:feat/fe-instance-flight
Jan 4, 2023
Merged

feat: Impl Insert functionality of Arrow Flight service for Frontend Instance#821
v0y4g3r merged 5 commits intoGreptimeTeam:developfrom
MichaelScofield:feat/fe-instance-flight

Conversation

@MichaelScofield
Copy link
Copy Markdown
Collaborator

@MichaelScofield MichaelScofield commented Jan 3, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR is part of a series of changes to gradually adopt the Arrow Flight, and remove the old GRPC interface finally.

This PR implements insert functionality of Arrow Flight service (handles InsertRequest in do_get) for Frontend instance.

Also:

  • add more unit tests for distributed mode
  • implement distributed alter table

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#381 #275

@MichaelScofield MichaelScofield force-pushed the feat/fe-instance-flight branch from aa352f8 to 8179f10 Compare January 4, 2023 02:55
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 4, 2023

Codecov Report

Merging #821 (7a1a945) into develop (4aa24f0) will increase coverage by 0.42%.
The diff coverage is 81.59%.

@@             Coverage Diff             @@
##           develop     #821      +/-   ##
===========================================
+ Coverage    85.23%   85.66%   +0.42%     
===========================================
  Files          418      420       +2     
  Lines        55251    55699     +448     
===========================================
+ Hits         47091    47712     +621     
+ Misses        8160     7987     -173     
Flag Coverage Δ
rust 85.66% <81.59%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/catalog/src/error.rs 74.68% <ø> (ø)
src/catalog/src/helper.rs 85.50% <0.00%> (-0.43%) ⬇️
src/catalog/src/local/manager.rs 68.80% <0.00%> (+5.59%) ⬆️
src/catalog/src/local/memory.rs 80.29% <0.00%> (-0.61%) ⬇️
src/datanode/src/instance.rs 54.12% <ø> (+10.54%) ⬆️
src/datanode/src/server/grpc.rs 93.67% <ø> (-0.04%) ⬇️
src/table/src/table.rs 50.00% <0.00%> (ø)
src/frontend/src/error.rs 8.77% <12.50%> (-0.49%) ⬇️
src/catalog/src/remote/manager.rs 71.04% <50.00%> (-0.08%) ⬇️
src/frontend/src/table.rs 93.39% <77.41%> (+3.49%) ⬆️
... and 51 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread src/common/grpc-expr/src/alter.rs Outdated
Comment thread src/frontend/src/error.rs Outdated
Comment thread src/frontend/src/instance/distributed.rs Outdated
Comment thread src/frontend/src/instance/distributed.rs
Comment thread src/frontend/src/instance/distributed.rs
Comment thread src/frontend/src/instance/grpc.rs
Comment thread src/frontend/src/table.rs Outdated
Co-authored-by: fys <40801205+Fengys123@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/frontend/src/instance/distributed.rs
Comment thread src/frontend/src/catalog.rs Outdated
Comment thread src/table/src/table.rs
@v0y4g3r v0y4g3r merged commit 50cc0e9 into GreptimeTeam:develop Jan 4, 2023
@MichaelScofield MichaelScofield deleted the feat/fe-instance-flight branch January 4, 2023 09:49
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…Instance (GreptimeTeam#821)

* feat: Implement Insert functionality of Arrow Flight service for Frontend Instance

* fix: update license content

* Update src/common/grpc-expr/src/alter.rs

Co-authored-by: fys <40801205+Fengys123@users.noreply.github.com>

* fix: resolve PR comments

* fix: resolve PR comments

Co-authored-by: fys <40801205+Fengys123@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants