feat: basic promql planner for single arg function call#828
Merged
waynexia merged 12 commits intoGreptimeTeam:developfrom Jan 5, 2023
Merged
feat: basic promql planner for single arg function call#828waynexia merged 12 commits intoGreptimeTeam:developfrom
waynexia merged 12 commits intoGreptimeTeam:developfrom
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #828 +/- ##
===========================================
+ Coverage 85.26% 85.92% +0.65%
===========================================
Files 418 422 +4
Lines 55285 56411 +1126
===========================================
+ Hits 47140 48469 +1329
+ Misses 8145 7942 -203
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
killme2008
reviewed
Jan 4, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
evenyag
reviewed
Jan 5, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
evenyag
approved these changes
Jan 5, 2023
yuanbohan
approved these changes
Jan 5, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…#828) * wip: draft planner Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * handle function args Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * a simple test Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * list all operators that accept 1 instant vector as input Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * simplify test cases Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * clean up Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * update cargo lock Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * CR suggessions Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * CR suggessions Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * change the way to handle metric name Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Implement a basic PromQL planner. It only supports prom functions that require one argument. You can find the list by searching
(v instant-vector)at https://prometheus.io/docs/prometheus/latest/querying/functions/, or check the unit tests.For example, give a simple promql query
This planner can generate plan like this (I skip the parser phase in unit test):
Checklist
Refer to a related PR or issue link (optional)