feat: use Python Script as UDF in SQL#839
Merged
killme2008 merged 9 commits intodevelopfrom Jan 13, 2023
Merged
Conversation
Member
|
Coooool! |
Codecov Report
@@ Coverage Diff @@
## develop #839 +/- ##
===========================================
+ Coverage 85.26% 86.29% +1.03%
===========================================
Files 418 422 +4
Lines 55285 55885 +600
===========================================
+ Hits 47140 48228 +1088
+ Misses 8145 7657 -488
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
There was a problem hiding this comment.
license-eye has totally checked 645 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 539 | 1 | 105 | 0 |
Click to see the invalid file list
- src/servers/tests/py_script/mod.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
waynexia
approved these changes
Jan 10, 2023
killme2008
reviewed
Jan 11, 2023
killme2008
reviewed
Jan 13, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: reg PyScript as UDF * refactor: use `ConcreteDataType` instead * fix: accept `str` data type * fix: allow binary to capture SIGINT * test: add test for py udf * Update src/servers/tests/py_script/mod.rs Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * style: clippy problem * style: add newline * chore: PR advices Co-authored-by: Ruihang Xia <waynestxia@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
So now you can use sql query like this:
where
system_statusis this python script:Now every time PyScript get insert&compile it will insert a UDF with same name
the relevant type is
PyUdfNeed to write explict return type in python script i.e. above
-> vector[str], so UDF know its' typeCan only return one value due to limitation of UDF(Even more vectors are returned, it will be ignore by UDF's
eval()functionChecklist
Refer to a related PR or issue link
#675 however still havn't support this feature of creating UDF in SQL(Might need to extend sql parser)
Also fix #232 with
Settingsto not let Python VM set SIGINT handler(so our tokio can take ctrl_c handler)