Skip to content

feat: expose wal config#852

Merged
evenyag merged 4 commits intoGreptimeTeam:developfrom
v0y4g3r:feat/wal-config
Jan 10, 2023
Merged

feat: expose wal config#852
evenyag merged 4 commits intoGreptimeTeam:developfrom
v0y4g3r:feat/wal-config

Conversation

@v0y4g3r
Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r commented Jan 9, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Allow users to config wal parameters thru config files.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 9, 2023

Codecov Report

Merging #852 (2d3e108) into develop (fa54870) will increase coverage by 0.25%.
The diff coverage is 92.25%.

@@             Coverage Diff             @@
##           develop     #852      +/-   ##
===========================================
+ Coverage    86.06%   86.32%   +0.25%     
===========================================
  Files          420      419       -1     
  Lines        55107    55027      -80     
===========================================
+ Hits         47429    47500      +71     
+ Misses        7678     7527     -151     
Flag Coverage Δ
rust 86.32% <92.25%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/base/src/lib.rs 100.00% <ø> (ø)
src/cmd/src/standalone.rs 56.30% <50.00%> (ø)
src/cmd/src/datanode.rs 78.23% <85.71%> (+0.76%) ⬆️
src/common/base/src/readable_size.rs 91.11% <91.11%> (ø)
src/datanode/src/datanode.rs 58.18% <100.00%> (+10.45%) ⬆️
src/datanode/src/instance.rs 53.33% <100.00%> (-16.67%) ⬇️
src/datanode/src/mock.rs 100.00% <100.00%> (ø)
src/frontend/src/tests.rs 95.62% <100.00%> (+1.27%) ⬆️
src/log-store/src/config.rs 100.00% <100.00%> (ø)
src/log-store/src/raft_engine/log_store.rs 88.86% <100.00%> (ø)
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/datanode/src/datanode.rs Outdated
Comment thread src/datanode/src/datanode.rs Outdated
@evenyag evenyag merged commit 90fcaa8 into GreptimeTeam:develop Jan 10, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: wal config

* fix: use human-readable string in wal config

* feat: copy ReadableSize and humanize size config items in toml files

* fix: clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants