feat: handle "USE <catalog>-<schema>" in MySQL#857
Merged
waynexia merged 2 commits intoGreptimeTeam:developfrom Jan 12, 2023
Merged
feat: handle "USE <catalog>-<schema>" in MySQL#857waynexia merged 2 commits intoGreptimeTeam:developfrom
waynexia merged 2 commits intoGreptimeTeam:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #857 +/- ##
===========================================
+ Coverage 86.09% 86.15% +0.06%
===========================================
Files 421 425 +4
Lines 55549 55858 +309
===========================================
+ Hits 47823 48123 +300
- Misses 7726 7735 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sunng87
reviewed
Jan 10, 2023
Collaborator
Author
|
@sunng87 PTAL |
MichaelScofield
force-pushed
the
feat/mysql-use-catalog
branch
from
828be15 to
23709a4
Compare
sunng87
approved these changes
Jan 10, 2023
sunng87
reviewed
Jan 10, 2023
MichaelScofield
force-pushed
the
feat/mysql-use-catalog
branch
from
23709a4 to
f78b55e
Compare
MichaelScofield
force-pushed
the
feat/mysql-use-catalog
branch
from
482e6ea to
029036b
Compare
killme2008
approved these changes
Jan 11, 2023
Member
killme2008
left a comment
killme2008
left a comment
There was a problem hiding this comment.
LGTM. Can you run the integration test in this branch before merging it? cargo run --bin sqlness-runner. Make sure it doesn't break any tests.
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: handle "USE <catalog>-<schema>" in MySQL * fix: resolve PR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Handles
USE <catalog>-<schema>in MySQL, as requested in #798Also do some refactors on SqlQueryHandler and GrpcQueryHandler, add associate types for implementors' errors, to get rid of the "map error to BoxedError then snafu context to server error" practice in implementors, gaining more coherence.
Checklist
Refer to a related PR or issue link (optional)
#670