feat: add --rpc-hostname option to datanode for a persist address to store in meta#871
Merged
fengjiachun merged 3 commits intoGreptimeTeam:developfrom Jan 17, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #871 +/- ##
===========================================
- Coverage 86.32% 86.13% -0.20%
===========================================
Files 422 425 +3
Lines 55669 56672 +1003
===========================================
+ Hits 48058 48812 +754
- Misses 7611 7860 +249
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
|
The option name may be confusing because it requires port as well. Or we can try to resolve port from edit: implemeted |
fengys1996
approved these changes
Jan 16, 2023
Co-authored-by: fys <40801205+Fengys123@users.noreply.github.com>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…store in meta (GreptimeTeam#871) * feat: add --rpc-hostname option * fix: config file and hostname parsing * Apply suggestions from code review Co-authored-by: fys <40801205+Fengys123@users.noreply.github.com> Co-authored-by: fys <40801205+Fengys123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
At the moment, we stored datanode's grpc IP address in meta. However when this address changes, via a deployment in k8s for example, it's impossible for frontend to find that datanode again. This patch adds a new start option
--rpc-hostnametodatanodestartup command and it will use value to report to meta.--rpc-addr, this behaviour is completely same to current--rpc-addr--rpc-hostnameresolves to--rpc-addrso that frontend can call datanode via this hostname. User can use0.0.0.0in--rpc-addras an exception, if the environment permitsChecklist
Refer to a related PR or issue link (optional)