feat: add authorize to UserProvider trait#879
Merged
sunng87 merged 17 commits intoGreptimeTeam:developfrom Jan 18, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 86.31% 86.19% -0.13%
===========================================
Files 427 427
Lines 57294 57280 -14
===========================================
- Hits 49456 49371 -85
- Misses 7838 7909 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shuiyisong
force-pushed
the
feat/schema_validator
branch
from
ba74393 to
15d87f6
Compare
shuiyisong
force-pushed
the
feat/schema_validator
branch
from
e56bc4f to
c60d49a
Compare
fengys1996
reviewed
Jan 17, 2023
fengys1996
approved these changes
Jan 17, 2023
shuiyisong
changed the title
schema_validator framework to authorize requestauthorize to UserProvider trait
sunng87
reviewed
Jan 18, 2023
MichaelScofield
approved these changes
Jan 18, 2023
sunng87
approved these changes
Jan 18, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: add SchemaValidator * feat: add schema validator to mysql shim * chore: pass schema validator to http auth layer * feat: add schema validator to http * feat: add schema validator to pg * feat: add schema validator to pg * feat: add schema validator test * chore: remove println in test * chore: use !matches * refactor: refac authenticate and authorize in http auth * refactor: refac authenticate and authorize in http auth * chore: typo * chore: minor change * refactor: merge schema_validator into user_providier * chore: fix license issue * refactor: change http query param from database to db * chore: fix cr issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
authtoauthenticateinUserProviderauthorizemethod toUserProviderto check user request's access permission to database(framework logic, no implementation yet)MysqlRuntimeOptionto aggregate mysql pass-through optionsdatabasetodbin http'sSqlQueryto better align with InfluxDB and promethuestodo
UserProviderChecklist
Refer to a related PR or issue link (optional)