refactor: support TLS private key of RSA format and add the full test certificates generation#885
Merged
killme2008 merged 1 commit intoGreptimeTeam:developfrom Jan 19, 2023
Conversation
… certificates generation chore: add the full certificate generation Signed-off-by: zyy17 <zyylsxm@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #885 +/- ##
===========================================
- Coverage 86.25% 86.21% -0.04%
===========================================
Files 425 427 +2
Lines 56638 57300 +662
===========================================
+ Hits 48853 49402 +549
- Misses 7785 7898 +113
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sunng87
approved these changes
Jan 17, 2023
killme2008
reviewed
Jan 17, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
… certificates generation (GreptimeTeam#885) chore: add the full certificate generation Signed-off-by: zyy17 <zyylsxm@gmail.com> Signed-off-by: zyy17 <zyylsxm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Support TLS private key of RSA format that is more common
Add the full test certificates generation
Execute the
src/servers/tests/ssl/gen-certs.shand it will generate the full self-signed certificates(including root CA) with private keys of RSA and PKCS8 format.Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)