feat: prunine sst files according to time range in filters#887
Merged
evenyag merged 8 commits intoGreptimeTeam:developfrom Jan 28, 2023
Merged
feat: prunine sst files according to time range in filters#887evenyag merged 8 commits intoGreptimeTeam:developfrom
evenyag merged 8 commits intoGreptimeTeam:developfrom
Conversation
v0y4g3r
requested review from
evenyag,
killme2008 and
waynexia
and removed request for
evenyag and
waynexia
Codecov Report
@@ Coverage Diff @@
## develop #887 +/- ##
===========================================
- Coverage 86.31% 86.16% -0.16%
===========================================
Files 427 427
Lines 57260 57529 +269
===========================================
+ Hits 49426 49570 +144
- Misses 7834 7959 +125
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evenyag
reviewed
Jan 17, 2023
evenyag
reviewed
Jan 18, 2023
v0y4g3r
force-pushed
the
feat/time-range-filter
branch
from
fcbf36f to
b43b19a
Compare
killme2008
reviewed
Jan 28, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…eam#887) * 1. Reimplement Eq for Timestamp 2. Add and/or for GenericRange * feat: extract time range from filters * feat: select sst files according to time range * fix: clippy * fix: empty value in range * fix: some cr comments * fix: return optional timestamp range * fix: cr comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Future work: we may need to benchmark this feature against a large dataset.
Checklist
Refer to a related PR or issue link (optional)
#846