feat: PromQL binary expr planner#889
Merged
waynexia merged 4 commits intoGreptimeTeam:developfrom Jan 29, 2023
Merged
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #889 +/- ##
===========================================
- Coverage 86.32% 86.15% -0.18%
===========================================
Files 425 427 +2
Lines 57005 57793 +788
===========================================
+ Hits 49209 49789 +580
- Misses 7796 8004 +208
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evenyag
reviewed
Jan 29, 2023
killme2008
reviewed
Jan 29, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
yuanbohan
approved these changes
Jan 29, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: PromQL binary expr planner Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * column & column test Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * column & literal test Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * mark literal-literal unsupported Signed-off-by: Ruihang Xia <waynestxia@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruihang Xia waynestxia@gmail.com
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Plan PromQL
Binaryexpression to datafusionLogicalPlan. Plan and expression are mixed in PromQL, so translating this part might not be very straightforward:INNER JOIN ON TIME INDEX, with operator applied to each value-column.Checklist
Refer to a related PR or issue link (optional)