Skip to content

ci: Skip status check on docs changed#903

Merged
fengjiachun merged 2 commits intoGreptimeTeam:developfrom
evenyag:ci/bypass-docs
Jan 28, 2023
Merged

ci: Skip status check on docs changed#903
fengjiachun merged 2 commits intoGreptimeTeam:developfrom
evenyag:ci/bypass-docs

Conversation

@evenyag
Copy link
Copy Markdown
Contributor

@evenyag evenyag commented Jan 28, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Marks the required status check as passed when the PR only changes files in the ignored path. It also moves the coverage test to the develop.yml so it can use the same action name CI.

See handling-skipped-but-required-checks

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 28, 2023

Codecov Report

Merging #903 (a466e1e) into develop (43aefc5) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #903      +/-   ##
===========================================
- Coverage    86.27%   86.15%   -0.12%     
===========================================
  Files          427      427              
  Lines        57529    57529              
===========================================
- Hits         49632    49565      -67     
- Misses        7897     7964      +67     
Flag Coverage Δ
rust 86.15% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/datanode/src/instance.rs 49.76% <0.00%> (-15.79%) ⬇️
tests-integration/src/test_util.rs 87.55% <0.00%> (-11.99%) ⬇️
src/common/substrait/src/types.rs 50.96% <0.00%> (-0.97%) ⬇️
src/frontend/src/table/scan.rs 90.74% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evenyag evenyag added the WIP label Jan 28, 2023
@evenyag
Copy link
Copy Markdown
Contributor Author

evenyag commented Jan 28, 2023

Experimenting with #836 , don't merge this please

@evenyag evenyag marked this pull request as draft January 28, 2023 07:51
@evenyag evenyag removed the WIP label Jan 28, 2023
@evenyag evenyag marked this pull request as ready for review January 28, 2023 07:56
@evenyag evenyag changed the title ci: Pass status check on docs changed ci: Skip status check on docs changed Jan 28, 2023
Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fengjiachun fengjiachun merged commit 3db8f95 into GreptimeTeam:develop Jan 28, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* ci: Pass status check on docs changed

* ci: Remove coverage.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants