Skip to content

refactor: move partition related code to partition manager#906

Merged
v0y4g3r merged 12 commits intoGreptimeTeam:developfrom
v0y4g3r:feat/partition-manager
Feb 1, 2023
Merged

refactor: move partition related code to partition manager#906
v0y4g3r merged 12 commits intoGreptimeTeam:developfrom
v0y4g3r:feat/partition-manager

Conversation

@v0y4g3r
Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r commented Jan 28, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Move partition rule related code to partition manager.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#901

@v0y4g3r v0y4g3r force-pushed the feat/partition-manager branch from 3557a22 to ec52fa9 Compare January 29, 2023 06:15
@v0y4g3r v0y4g3r marked this pull request as ready for review January 29, 2023 14:59
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2023

Codecov Report

Merging #906 (a97b88b) into develop (8149932) will increase coverage by 0.00%.
The diff coverage is 83.38%.

@@           Coverage Diff            @@
##           develop     #906   +/-   ##
========================================
  Coverage    86.14%   86.14%           
========================================
  Files          434      437    +3     
  Lines        58411    58417    +6     
========================================
+ Hits         50316    50324    +8     
+ Misses        8095     8093    -2     
Flag Coverage Δ
rust 86.14% <83.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/instance.rs 70.91% <0.00%> (-0.27%) ⬇️
src/frontend/src/lib.rs 100.00% <ø> (ø)
src/partition/src/error.rs 0.00% <0.00%> (ø)
src/frontend/src/error.rs 11.76% <20.00%> (ø)
src/frontend/src/instance/distributed.rs 92.15% <60.00%> (+0.01%) ⬆️
src/frontend/src/table/insert.rs 96.50% <71.42%> (-1.31%) ⬇️
src/partition/src/manager.rs 88.95% <88.95%> (ø)
src/frontend/src/table.rs 94.25% <93.33%> (+0.26%) ⬆️
src/frontend/src/catalog.rs 70.90% <100.00%> (ø)
src/frontend/src/tests.rs 95.78% <100.00%> (+0.04%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread src/frontend/src/error.rs Outdated
Comment thread src/partition/src/columns.rs Outdated
Comment thread src/partition/src/manager.rs Outdated
Comment thread src/partition/src/range.rs Outdated
@v0y4g3r v0y4g3r force-pushed the feat/partition-manager branch from bdb751d to d1a3fc3 Compare January 30, 2023 07:06
@v0y4g3r v0y4g3r requested a review from evenyag January 31, 2023 07:36
@v0y4g3r v0y4g3r force-pushed the feat/partition-manager branch from d1a3fc3 to 2187fb1 Compare January 31, 2023 08:13
Comment thread src/partition/Cargo.toml Outdated
Comment thread src/partition/Cargo.toml Outdated
Comment thread src/partition/src/lib.rs Outdated
Comment thread src/partition/src/lib.rs Outdated
Comment thread src/partition/src/manager.rs Outdated
@v0y4g3r v0y4g3r requested a review from evenyag February 1, 2023 11:02
Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit 028a69e into GreptimeTeam:develop Feb 1, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…eam#906)

* wip: fix compile errors

* chore: move splitter to partition crate

* fix: remove useless variants in frontend errors

* chore: move more partition related code to partition manager

* fix: license header

* wip: move WriteSplitter to PartitionRuleManager

* fix: clippy warnings

* chore: remove useless error variant and format toml

* fix: cr comments

* chore: resolve conflicts

* chore: rebase develop

* fix: cr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants