refactor: move partition related code to partition manager#906
Merged
v0y4g3r merged 12 commits intoGreptimeTeam:developfrom Feb 1, 2023
Merged
refactor: move partition related code to partition manager#906v0y4g3r merged 12 commits intoGreptimeTeam:developfrom
v0y4g3r merged 12 commits intoGreptimeTeam:developfrom
Conversation
3557a22 to
ec52fa9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #906 +/- ##
========================================
Coverage 86.14% 86.14%
========================================
Files 434 437 +3
Lines 58411 58417 +6
========================================
+ Hits 50316 50324 +8
+ Misses 8095 8093 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d9bb330 to
bdb751d
Compare
bdb751d to
d1a3fc3
Compare
MichaelScofield
approved these changes
Jan 30, 2023
d1a3fc3 to
2187fb1
Compare
evenyag
reviewed
Jan 31, 2023
2 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…eam#906) * wip: fix compile errors * chore: move splitter to partition crate * fix: remove useless variants in frontend errors * chore: move more partition related code to partition manager * fix: license header * wip: move WriteSplitter to PartitionRuleManager * fix: clippy warnings * chore: remove useless error variant and format toml * fix: cr comments * chore: resolve conflicts * chore: rebase develop * fix: cr comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Move partition rule related code to partition manager.
Checklist
Refer to a related PR or issue link (optional)
#901