Skip to content

feat: local catalog drop table#913

Merged
waynexia merged 4 commits intoGreptimeTeam:developfrom
MichaelScofield:feat/local-catalog-drop-table
Jan 31, 2023
Merged

feat: local catalog drop table#913
waynexia merged 4 commits intoGreptimeTeam:developfrom
MichaelScofield:feat/local-catalog-drop-table

Conversation

@MichaelScofield
Copy link
Copy Markdown
Collaborator

@MichaelScofield MichaelScofield commented Jan 29, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • impl drop table on local catalog (part of Support drop table clause #497)
  • fix a minor bug that default value of BinaryType is Value::String (should be Value::Binary)
  • change sqlness tests accordingly

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2023 •
edited
Loading

Codecov Report

Merging #913 (57fd376) into develop (dc9b533) will decrease coverage by 0.16%.
The diff coverage is 68.75%.

@@             Coverage Diff             @@
##           develop     #913      +/-   ##
===========================================
- Coverage    86.25%   86.10%   -0.16%     
===========================================
  Files          430      430              
  Lines        57928    58297     +369     
===========================================
+ Hits         49968    50195     +227     
- Misses        7960     8102     +142
Flag Coverage Δ
rust 86.10% <68.75%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/catalog/src/lib.rs 88.60% <0.00%> (ø)
src/catalog/src/local/manager.rs 69.60% <0.00%> (-3.22%) ⬇️
src/catalog/src/tables.rs 82.27% <0.00%> (-4.05%) ⬇️
src/catalog/src/error.rs 75.00% <57.14%> (+0.31%) ⬆️
src/catalog/src/local/memory.rs 85.59% <66.66%> (-0.16%) ⬇️
src/datanode/src/sql.rs 82.58% <90.00%> (+9.69%) ⬆️
src/catalog/src/system.rs 94.75% <97.61%> (+4.25%) ⬆️
src/datanode/src/error.rs 65.95% <100.00%> (ø)
src/datatypes/src/types/binary_type.rs 86.36% <100.00%> (+13.63%) ⬆️
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MichaelScofield MichaelScofield mentioned this pull request Jan 30, 2023
Closed
7 tasks
v0y4g3r
v0y4g3r reviewed Jan 30, 2023
View reviewed changes
Comment thread src/catalog/src/local/manager.rs Outdated
Comment thread src/catalog/src/local/manager.rs Outdated
Comment thread src/catalog/src/error.rs
Comment thread src/catalog/src/system.rs
MichaelScofield and others added 3 commits January 30, 2023 17:18
@MichaelScofield @v0y4g3r
Update src/catalog/src/local/manager.rs
edc246b 
Co-authored-by: Lei, HUANG <6406592+v0y4g3r@users.noreply.github.com>
@MichaelScofield @v0y4g3r
Update src/catalog/src/local/manager.rs
2666e48 
Co-authored-by: Lei, HUANG <6406592+v0y4g3r@users.noreply.github.com>
@MichaelScofield
fix: resolve PR comments
57fd376
@MichaelScofield
Copy link
Copy Markdown
Collaborator Author

MichaelScofield commented Jan 30, 2023

@v0y4g3r PTAL

evenyag
evenyag reviewed Jan 31, 2023
View reviewed changes
Comment thread tests/cases/standalone/order/order_variable_size_payload.result
Comment thread tests/cases/standalone/catalog/schema.sql
evenyag
evenyag approved these changes Jan 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This should be fine.

waynexia
waynexia approved these changes Jan 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit 8149932 into GreptimeTeam:develop Jan 31, 2023
@MichaelScofield MichaelScofield deleted the feat/local-catalog-drop-table branch January 31, 2023 06:54
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@MichaelScofield @v0y4g3r @paomian
feat: local catalog drop table (GreptimeTeam#913)
0a682b1 
* feat: local catalog drop table

* Update src/catalog/src/local/manager.rs

Co-authored-by: Lei, HUANG <6406592+v0y4g3r@users.noreply.github.com>

* Update src/catalog/src/local/manager.rs

Co-authored-by: Lei, HUANG <6406592+v0y4g3r@users.noreply.github.com>

* fix: resolve PR comments

---------

Co-authored-by: Lei, HUANG <6406592+v0y4g3r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v0y4g3r v0y4g3r v0y4g3r left review comments

@waynexia waynexia waynexia approved these changes

@evenyag evenyag evenyag approved these changes

@killme2008 killme2008 Awaiting requested review from killme2008

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichaelScofield @v0y4g3r @evenyag @waynexia