revert: removed all "USE"s in sqlness tests introduced in #922#938
Merged
killme2008 merged 1 commit intoGreptimeTeam:developfrom Feb 3, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #938 +/- ##
===========================================
- Coverage 86.04% 85.94% -0.11%
===========================================
Files 439 439
Lines 58653 58653
===========================================
- Hits 50469 50407 -62
- Misses 8184 8246 +62
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
waynexia
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Because the "USE"s in sqlness test cases could introduce another burden for writing tests, it's better to remove them. Thus all test cases are using the default "public" schema if not explicitly specified using "USE". And to test "USE", we have to reset the schema to default "public" using "USE public" at the end of test case.
Checklist
Refer to a related PR or issue link (optional)
Revert part of #922