feat: Support the DELETE SQL statement#942
Merged
evenyag merged 38 commits intoGreptimeTeam:developfrom Feb 15, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #942 +/- ##
===========================================
+ Coverage 86.05% 86.12% +0.07%
===========================================
Files 431 435 +4
Lines 61600 62642 +1042
===========================================
+ Hits 53008 53949 +941
- Misses 8592 8693 +101
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
waynexia
reviewed
Feb 9, 2023
Contributor
Author
|
PTAL:D @waynexia |
waynexia
approved these changes
Feb 9, 2023
Member
waynexia
left a comment
waynexia
left a comment
There was a problem hiding this comment.
Mostly looks good to me 👍 , only left some tiny comments about style.
evenyag
reviewed
Feb 9, 2023
evenyag
reviewed
Feb 10, 2023
Contributor
Author
|
PTAL:D @evenyag |
evenyag
reviewed
Feb 13, 2023
evenyag
reviewed
Feb 14, 2023
evenyag
approved these changes
Feb 15, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* [WIP]:delete sql * [fix]:time parser bug * [fix]:resolve conflict * [fmt]:cargo fmt * [fix]:remove unless log * [fix]:test * [feat]:add error parse * [fix]:resolve conflict * [fix]:remove unless code * [fix]:remove unless code * [test]:add IT * [fix]:add license * [fix]:ci * [fix]:ci * [fix]:ci * [fix]:remove * [fix]:ci * [feat]:add sql * [fix]:modify sql * [feat]:refactor parser_expr * [feat]:rm backtrace * [fix]:ci * [fix]: conversation * [fix]: conversation * feat:refactor delete * feat:refactor delete * fix:resolve conversation * fix:ut * fix:ut * fix:conversation * fix:conversation * fix:conservation --------- Co-authored-by: xieqijun <qijun@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Support the DELETE SQL statement but require specifying the full primary key (and the timestamp)
Checklist
Refer to a related PR or issue link
issue : #755