Skip to content

feat: datanode stats is stored in the mem_kv of meta leader#943

Merged
fengys1996 merged 6 commits intoGreptimeTeam:developfrom
fengys1996:feat/meta/cluster
Feb 7, 2023
Merged

feat: datanode stats is stored in the mem_kv of meta leader#943
fengys1996 merged 6 commits intoGreptimeTeam:developfrom
fengys1996:feat/meta/cluster

Conversation

@fengys1996
Copy link
Copy Markdown
Contributor

@fengys1996 fengys1996 commented Feb 5, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr main change:

  1. datanode stats is store in the mem_kv store of the meta leader, instead of etcd kv store.
  2. add a cluster grpc service.
  3. add an http api to query all heartbeat data(or datanode stats).
curl http://127.0.0.1:3002/admin/heartbeat

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@fengys1996 fengys1996 marked this pull request as ready for review February 6, 2023 03:51
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2023

Codecov Report

Merging #943 (8e273f8) into develop (b0925d9) will decrease coverage by 0.53%.
The diff coverage is 54.56%.

@@             Coverage Diff             @@
##           develop     #943      +/-   ##
===========================================
- Coverage    85.88%   85.36%   -0.53%     
===========================================
  Files          443      450       +7     
  Lines        59202    60226    +1024     
===========================================
+ Hits         50848    51409     +561     
- Misses        8354     8817     +463     
Flag Coverage Δ
rust 85.36% <54.56%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta-srv/src/bootstrap.rs 0.00% <0.00%> (ø)
src/meta-srv/src/error.rs 94.76% <ø> (-0.59%) ⬇️
src/meta-srv/src/lib.rs 100.00% <ø> (ø)
src/meta-srv/src/metasrv.rs 61.53% <0.00%> (-11.19%) ⬇️
src/meta-srv/src/selector/load_based.rs 28.07% <0.00%> (-49.63%) ⬇️
src/meta-srv/src/service/admin.rs 73.54% <0.00%> (-3.48%) ⬇️
src/meta-srv/src/service/admin/heartbeat.rs 0.00% <0.00%> (ø)
src/meta-srv/src/service/cluster.rs 0.00% <0.00%> (ø)
src/meta-srv/src/cluster.rs 48.71% <48.71%> (ø)
src/meta-srv/src/metasrv/builder.rs 77.01% <77.01%> (ø)
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fengys1996 fengys1996 changed the title feat: datanode stats is stored in the mem_kv of the meta leader feat: datanode stats is stored in the mem_kv of meta leader Feb 6, 2023
Comment thread src/meta-srv/src/error.rs Outdated
Comment thread src/meta-srv/src/error.rs Outdated
Comment thread src/meta-srv/src/keys.rs
Comment thread src/meta-srv/src/service/admin/heartbeat.rs Outdated
Comment thread src/meta-srv/src/service/cluster.rs Outdated
Comment thread src/meta-srv/src/metasrv.rs Outdated
Comment thread src/meta-srv/src/metasrv.rs Outdated
Comment thread src/meta-srv/src/metasrv.rs Outdated
Comment thread src/api/greptime/v1/meta/cluster.proto Outdated
Comment thread src/api/greptime/v1/meta/cluster.proto Outdated
Comment thread src/meta-srv/src/metasrv/builder.rs Outdated
@fengys1996 fengys1996 merged commit 83509f3 into GreptimeTeam:develop Feb 7, 2023
@fengys1996 fengys1996 deleted the feat/meta/cluster branch February 7, 2023 09:09
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…Team#943)

* store heartbeat data in memory, instead of etcd

* fix: typo

* fix: license header

* cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants