Skip to content

chore: alias sqlness subcommand#956

Merged
killme2008 merged 1 commit intoGreptimeTeam:developfrom
waynexia:sqlness-alias
Feb 7, 2023
Merged

chore: alias sqlness subcommand#956
killme2008 merged 1 commit intoGreptimeTeam:developfrom
waynexia:sqlness-alias

Conversation

@waynexia
Copy link
Copy Markdown
Member

@waynexia waynexia commented Feb 7, 2023

Signed-off-by: Ruihang Xia waynestxia@gmail.com

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

simplify the sqlness command to cargo sqlness. But the previous cargo run --bin sqlness-runner is still avaliable

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2023

Codecov Report

Merging #956 (1e68517) into develop (ecadbc1) will decrease coverage by 0.42%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #956      +/-   ##
===========================================
- Coverage    85.74%   85.33%   -0.42%     
===========================================
  Files          444      450       +6     
  Lines        59828    60226     +398     
===========================================
+ Hits         51301    51395      +94     
- Misses        8527     8831     +304     
Flag Coverage Δ
rust 85.33% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/meta-srv/src/selector/load_based.rs 28.07% <0.00%> (-49.63%) ⬇️
src/datanode/src/instance.rs 41.56% <0.00%> (-16.21%) ⬇️
src/meta-srv/src/metasrv.rs 61.53% <0.00%> (-11.19%) ⬇️
tests-integration/src/test_util.rs 79.47% <0.00%> (-9.92%) ⬇️
src/meta-srv/src/service/admin.rs 73.54% <0.00%> (-3.48%) ⬇️
src/sql/src/parser.rs 77.02% <0.00%> (-2.09%) ⬇️
src/common/substrait/src/df_expr.rs 30.16% <0.00%> (-0.66%) ⬇️
src/meta-srv/src/service/router.rs 78.32% <0.00%> (-0.64%) ⬇️
src/mito/src/table.rs 88.08% <0.00%> (-0.52%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Member

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 37ca5ba into GreptimeTeam:develop Feb 7, 2023
@waynexia waynexia deleted the sqlness-alias branch February 7, 2023 11:11
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants