Skip to content

chore: add an opaque error type in meta#959

Merged
sunng87 merged 1 commit intoGreptimeTeam:developfrom
fengys1996:feat/meta/boxederr
Feb 8, 2023
Merged

chore: add an opaque error type in meta#959
sunng87 merged 1 commit intoGreptimeTeam:developfrom
fengys1996:feat/meta/boxederr

Conversation

@fengys1996
Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly add an opaque error type in meta, to facilitate error handling in extension modules

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link
Copy Markdown
Contributor

@shuiyisong shuiyisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 enabled auto-merge (squash) February 8, 2023 09:33
@sunng87 sunng87 merged commit 4ce62f8 into GreptimeTeam:develop Feb 8, 2023
@fengys1996 fengys1996 deleted the feat/meta/boxederr branch February 16, 2023 14:47
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants