fix: remove incorrect table_idents_to_full_name#967
Merged
shuiyisong merged 3 commits intoGreptimeTeam:developfrom Feb 10, 2023
Merged
fix: remove incorrect table_idents_to_full_name#967shuiyisong merged 3 commits intoGreptimeTeam:developfrom
table_idents_to_full_name#967shuiyisong merged 3 commits intoGreptimeTeam:developfrom
Conversation
sunng87
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly removes the incorrect
table_idents_to_full_namefunction and change usage to the right one usingquery_ctxChecklist
Refer to a related PR or issue link (optional)