feat: Implement LocalManager::recover#981
Merged
v0y4g3r merged 2 commits intoGreptimeTeam:developfrom Feb 14, 2023
Merged
Conversation
93b6118 to
b88e3ea
Compare
37 tasks
Codecov Report
@@ Coverage Diff @@
## develop #981 +/- ##
===========================================
- Coverage 85.74% 85.65% -0.09%
===========================================
Files 461 461
Lines 62932 62982 +50
===========================================
- Hits 53962 53949 -13
- Misses 8970 9033 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MichaelScofield
approved these changes
Feb 13, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: Implement LocalManager::recover * feat: Impl From<ObjectStore> for ProcedureStore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements
LocalManager::recoverthat recover uncommitted procedures fromProcedureStoreand re-submits them to execute.Recovery
LocalManagerloads messages of all uncommitted procedures fromProcedureStoreand caches in memory.LocalManagerjust submit the root procedure to execute.This simplify the recover process a lot as we don't need to reconstruct the whole DAG.
Checklist
Refer to a related PR or issue link (optional)