feat: handle PromQL HTTP API parameters#985
Merged
sunng87 merged 14 commits intoGreptimeTeam:developfrom Feb 15, 2023
Merged
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #985 +/- ##
===========================================
- Coverage 86.01% 85.97% -0.04%
===========================================
Files 436 436
Lines 62930 63084 +154
===========================================
+ Hits 54128 54236 +108
- Misses 8802 8848 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
yuanbohan
approved these changes
Feb 14, 2023
killme2008
reviewed
Feb 14, 2023
sunng87
reviewed
Feb 14, 2023
killme2008
reviewed
Feb 14, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
sunng87
reviewed
Feb 14, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
sunng87
approved these changes
Feb 15, 2023
5 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: impl EvalStmt parser Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * fix compile errors Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * update test result Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * add integration test Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * fix clippy Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * resolve CR comments Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * impl From<PromqlQuery> for PromQuery Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * move format into with_context Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * update test result Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * shorthand compound error Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * use rfc3339 error to report float parsing error Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * remove CompoundError Signed-off-by: Ruihang Xia <waynestxia@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add
start,endandstep's parser part to promql'sEvalStmt. And process them in the exposed HTTP API.Notice that the
lookbackin promql is set in something like query context. We may expose it in the HTTP API in the future, but for this PR it's ignored.Checklist
Refer to a related PR or issue link (optional)