Skip to content

feat: add retry logic for MetaPeerClient#991

Merged
fengys1996 merged 9 commits intoGreptimeTeam:developfrom
fengys1996:fix/meta/retry
Feb 15, 2023
Merged

feat: add retry logic for MetaPeerClient#991
fengys1996 merged 9 commits intoGreptimeTeam:developfrom
fengys1996:fix/meta/retry

Conversation

@fengys1996
Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly change: add retry logic for MetaPeerClient.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@fengys1996 fengys1996 marked this pull request as ready for review February 14, 2023 10:06
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2023

Codecov Report

Merging #991 (2d7874e) into develop (8491f65) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #991      +/-   ##
===========================================
- Coverage    86.05%   85.91%   -0.15%     
===========================================
  Files          431      432       +1     
  Lines        61600    62542     +942     
===========================================
+ Hits         53008    53731     +723     
- Misses        8592     8811     +219     
Flag Coverage Δ
rust 85.91% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta-srv/src/bootstrap.rs 0.00% <0.00%> (ø)
src/meta-srv/src/cluster.rs 39.17% <0.00%> (-9.55%) ⬇️
src/meta-srv/src/service/cluster.rs 0.00% <0.00%> (ø)
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/storage/src/compaction/task.rs 7.47% <0.00%> (-59.20%) ⬇️
src/datanode/src/instance.rs 41.56% <0.00%> (-14.91%) ⬇️
src/storage/src/compaction/picker.rs 26.53% <0.00%> (-11.71%) ⬇️
tests-integration/src/test_util.rs 79.47% <0.00%> (-9.33%) ⬇️
src/storage/src/read.rs 89.88% <0.00%> (-2.97%) ⬇️
src/storage/src/test_util/read_util.rs 92.78% <0.00%> (-1.58%) ⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread src/meta-srv/src/bootstrap.rs Outdated
Comment thread src/meta-srv/src/cluster.rs Outdated
Comment thread src/meta-srv/src/cluster.rs Outdated
Comment thread src/meta-srv/src/service/cluster.rs Outdated
Comment thread src/meta-srv/src/bootstrap.rs Outdated
@fengys1996
Copy link
Copy Markdown
Contributor Author

PTAL @shuiyisong

@fengys1996 fengys1996 merged commit e2904b9 into GreptimeTeam:develop Feb 15, 2023
@fengys1996 fengys1996 deleted the fix/meta/retry branch February 15, 2023 06:12
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* add retry logic in meta_peer_client

* impl need_retry function

* create meta_peer_client using the builder pattern

* cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants