Skip to content

feat: duplicate error logs into separate file#995

Merged
waynexia merged 1 commit intoGreptimeTeam:developfrom
lizhemingi:add-err-log-file
Feb 15, 2023
Merged

feat: duplicate error logs into separate file#995
waynexia merged 1 commit intoGreptimeTeam:developfrom
lizhemingi:add-err-log-file

Conversation

@lizhemingi
Copy link
Copy Markdown
Contributor

@lizhemingi lizhemingi commented Feb 14, 2023

Signed-off-by: Zheming Li nkdudu@126.com

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Duplicate error logs into a separate file.

msfRDOGkW6

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#805

Signed-off-by: Zheming Li <nkdudu@126.com>
@waynexia waynexia requested review from evenyag and waynexia February 14, 2023 09:41
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2023

Codecov Report

Merging #995 (1e50e00) into develop (9ad6c45) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #995      +/-   ##
===========================================
- Coverage    85.99%   85.95%   -0.04%     
===========================================
  Files          431      431              
  Lines        61557    61610      +53     
===========================================
+ Hits         52934    52959      +25     
- Misses        8623     8651      +28     
Flag Coverage Δ
rust 85.95% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/telemetry/src/logging.rs 89.69% <100.00%> (+1.18%) ⬆️
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/datanode/src/instance.rs 41.56% <0.00%> (-14.91%) ⬇️
src/storage/src/compaction/dedup_deque.rs 72.91% <0.00%> (-10.42%) ⬇️
tests-integration/src/test_util.rs 79.47% <0.00%> (-9.33%) ⬇️
src/meta-client/src/rpc/util.rs 72.22% <0.00%> (-5.56%) ⬇️
src/servers/src/auth/user_provider.rs 81.81% <0.00%> (-2.28%) ⬇️
src/storage/src/compaction/scheduler.rs 92.00% <0.00%> (-1.34%) ⬇️
src/servers/src/opentsdb/handler.rs 93.81% <0.00%> (-1.04%) ⬇️
src/mito/src/engine.rs 97.72% <0.00%> (-0.67%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag requested a review from killme2008 February 15, 2023 05:20
Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@waynexia waynexia merged commit a19dee1 into GreptimeTeam:develop Feb 15, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants