fix: Fix context passed to GraphQL::Schema.federation_sdl #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jturkel
changed the title
jturkel
force-pushed
the
feature/sdl-context
branch
from
1b2a9a6 to
c368a94
Compare
rylanc
suggested changes
Sep 22, 2020
jturkel
force-pushed
the
feature/sdl-context
branch
from
c368a94 to
9009cdc
Compare
|
@rylanc - I rebased on top of master and the tests are passing. |
jturkel
force-pushed
the
feature/sdl-context
branch
from
9009cdc to
7b75258
Compare
|
@rylanc - Looks like another merge conflict snuck in so I rebased the PR. |
rylanc
approved these changes
Oct 29, 2020
|
🎉 This PR is included in version 1.1.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where
ApolloFederation::ServiceField#_servicepassed acontextof typeGraphQL::Query::Contextrather thanHashwhich violates the contract of GraphQL::Language::DocumentFromSchemaDefinition#initialize. The API ofGraphQL::Query::ContextandHashare similar enough that this didn't cause any problems until graphql-ruby 1.9.17 with the introduction of context scoping. After that change, callingto_h,fetchordigon the context from anywhere in the resolution ofApolloFederation::ServiceField#_service(e.g. schema visibility checks) would result in aNoMethodError: undefined methodmerge' for #<Query::Context ...>`.