Skip to content

sniffnet doesn't respect --help and --version flags #264

Closed

Description

@Aloso

Describe the bug
Running sniffnet --help or sniffnet --version should display information in the terminal without starting the GUI.

To Reproduce

  1. Run sniffnet --help or sniffnet --version

Expected behavior
The GUI should not start.

sniffnet --help should show what CLI flags are supported (it should support at least --help and --version).

sniffnet --version should display the current version.

Desktop (please complete the following information):

  • OS: Linux
  • Version 1.2.1

Activity

  1. GyulyVGC commented on Jun 8, 2023

    @GyulyVGC
    Owner

    It's definitely something I will implement.
    Thanks for pointing out.

  2. added this to the v1.2.2 milestone on Jun 8, 2023
  3. gautamprikshit1 commented on Jun 12, 2023

    @gautamprikshit1

    @GyulyVGC any pointers on how to resolve it?

  4. GyulyVGC commented on Jun 12, 2023

    @GyulyVGC
    Owner

    @GyulyVGC any pointers on how to resolve it?

    It's not a problem, but more something that has to be reimplemented.
    Sniffnet used to be a CLI in the past and arguments were parsed with clap.
    I think I will use a similar approach to reintroduce them, launching the app as a GUI only if not present.

  5. GyulyVGC commented on Jun 17, 2023

    @GyulyVGC
    Owner

    Done!
    Thanks to @Aloso for having implemented this feature in #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature, request, or improvement

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions