Skip to content

Add Ukrainian translation for version 1.3. - #692

Merged
GyulyVGC merged 4 commits into
GyulyVGC:mainfrom
Kapelianovych:feat/ukrainian-translation-v3
Feb 1, 2025
Merged

GyulyVGC merged 4 commits into
GyulyVGC:mainfrom
Kapelianovych:feat/ukrainian-translation-v3

Conversation

@Kapelianovych

Copy link
Copy Markdown
Contributor

I have updated the Ukrainian translation to support 1.3 version and fixed some existing translations (mostly making it more polite and removing obvious mistakes).

Marked Ukrainian translation as up to date.
Add a note to the CHANGELOG.
@Kapelianovych
Kapelianovych marked this pull request as ready for review February 1, 2025 17:48
@GyulyVGC GyulyVGC added the translation User interface translation label Feb 1, 2025
@GyulyVGC GyulyVGC added this to the v1.4.0 milestone Feb 1, 2025
@GyulyVGC

GyulyVGC commented Feb 1, 2025

Copy link
Copy Markdown
Owner

It doesn't happen often that a contributor also takes care of updating the changelog.
Thanks so much for your time!

@GyulyVGC

GyulyVGC commented Feb 1, 2025

Copy link
Copy Markdown
Owner

@all-contributors please add @Kapelianovych for translation.

@allcontributors

Copy link
Copy Markdown
Contributor

@GyulyVGC

I've put up a pull request to add @Kapelianovych! 🎉

@GyulyVGC
GyulyVGC merged commit ec1bdf2 into GyulyVGC:main Feb 1, 2025
Comment thread src/translations/translations.rs Outdated
Language::ES => "paquetes por segundo",
Language::PL => "pakiety na sekundę",
Language::DE => "Pakete pro Sekunde",
Language::UK => "пакети(ів) на секунду",

@Kapelianovych Kapelianovych Feb 1, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GyulyVGC I personally wasn't able to check where this translation is used, but there is a special type of conjugation in Ukrainian language which depends on a preceding number. For example, if there is a 2 packets per second, it translates to 2 пакети на секунду, but 11 packets per second translates to 11 пакетів на секунду. Considering that I added parentheses with alternative ending. It might not be needed if there won't be such situation though.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I actually removed the (ів) from all the cases since I think it's fine to also use the singular. By the way that translation is used on the traffic chart heading when you switch to packets as data representation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Well, let it be like this for now. Maybe in future i18n feature can be improved to infer a context for a translation.

@Kapelianovych
Kapelianovych deleted the feat/ukrainian-translation-v3 branch February 1, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation User interface translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants