chore: remove dead OLLAMA_NUM_CTX / args.ollama_num_ctx assignment#2888
Merged
danielaskdd merged 1 commit intoHKUDS:mainfrom Apr 3, 2026
Merged
Conversation
`args.ollama_num_ctx` is written from the `OLLAMA_NUM_CTX` environment variable but is never read anywhere in the codebase. The actual Ollama context-window size is controlled via the typed binding-options system: `OllamaLLMOptions` reads `OLLAMA_LLM_NUM_CTX` and `OllamaEmbeddingOptions` reads `OLLAMA_EMBEDDING_NUM_CTX`, both via their `add_args()` / `options_dict()` methods. Removing the two dead lines prevents confusion for anyone who traces the `OLLAMA_NUM_CTX` name and wonders why it has no effect. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.pyline 360 reads theOLLAMA_NUM_CTXenvironment variable and stores it inargs.ollama_num_ctx, but that attribute is never read anywhere else in the codebase:The actual Ollama context-window size is handled entirely by the typed
BindingOptionssystem:OllamaLLMOptionsOLLAMA_LLM_NUM_CTX--ollama-llm-num_ctxOllamaEmbeddingOptionsOLLAMA_EMBEDDING_NUM_CTX--ollama-embedding-num_ctxenv.exampleand the API READMEs already document the correct names (OLLAMA_LLM_NUM_CTX/OLLAMA_EMBEDDING_NUM_CTX). The deadOLLAMA_NUM_CTXassignment just creates confusion for anyone tracing why that variable has no effect.Tests