fix(provider): preserve reasoning_content when merging consecutive assistant messages#3419
Closed
chengyongru wants to merge 1 commit intomainfrom
Closed
fix(provider): preserve reasoning_content when merging consecutive assistant messages#3419chengyongru wants to merge 1 commit intomainfrom
chengyongru wants to merge 1 commit intomainfrom
Conversation
…sistant messages DeepSeek thinking mode requires reasoning_content to be passed back in all subsequent API requests when tool calls were involved. The _enforce_role_alternation method silently dropped reasoning_content when merging consecutive assistant messages, causing a 400 error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_enforce_role_alternation()silently droppingreasoning_contentwhen merging consecutive assistant messages_carry_over_reasoning()helper to preserve and concatenatereasoning_contentacross all 4 merge branches in_enforce_role_alternation()reasoning_content,thinking_blocks,tool_calls) when recovering trailing assistant messages as user roleRoot Cause
DeepSeek thinking mode requires
reasoning_contentto be passed back in all subsequent API requests when tool calls were involved. The_enforce_role_alternation()method merged consecutive assistant messages by concatenatingcontentbut silently discardedreasoning_content, triggering:This could occur after history truncation (
_snip_history) or checkpoint restoration created consecutive assistant messages.Changes
nanobot/providers/base.py— New_carry_over_reasoning(src, dst)helper + integration into all merge branches + recovery path cleanuptests/providers/test_enforce_role_alternation.py— 8 new test cases covering reasoning_content preservationTest plan