fix: adjust DeepSeek reasoning mode check condition#3560
Merged
Conversation
Contributor
JiajunBernoulli
commented
Apr 30, 2026
- Modified _drop_deepseek_incomplete_reasoning_history to properly handle reasoning mode detection
- Fixes issue DeepSeek-V4 reasoning_content error still reproducible on v0.1.5.post3 with WebUI + exec tool on Windows #3554
- Modified _drop_deepseek_incomplete_reasoning_history to properly handle reasoning mode detection - Fixes issue HKUDS#3554
Re-bin
approved these changes
May 1, 2026
Collaborator
Re-bin
left a comment
There was a problem hiding this comment.
LGTM after the follow-up fixes.
The DeepSeek history cleanup is now scoped narrowly:
- Explicit thinking mode still cleans up incomplete reasoning history.
- Implicit cleanup only applies to known thinking-capable DeepSeek models such as
deepseek-v4/deepseek-reasoner. - Non-thinking
deepseek-chatkeeps normal tool-call history intact.
Regression coverage was added for both the implicit deepseek-v4-pro case and the deepseek-chat non-trimming case.
Verified locally:
uv run pytest tests/providers/test_litellm_kwargs.py -k 'deepseek' -quv run ruff check nanobot/providers/openai_compat_provider.pygit diff --check
Ready to merge once CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.