Skip to content

Create 5 GitHub issues for fighter body model improvements#1154

Merged
pethers merged 1 commit into
mainfrom
copilot/improve-fighter-look-and-feel
Jan 13, 2026
Merged

Create 5 GitHub issues for fighter body model improvements#1154
pethers merged 1 commit into
mainfrom
copilot/improve-fighter-look-and-feel

Conversation

Copilot AI commented Jan 11, 2026

Copy link
Copy Markdown
Contributor

Created 5 GitHub issues to address missing feet, clothing system, and muscle/fat scaling problems in fighter 3D models. Current skeletal models have invisible feet, no clothing, and insufficient visual distinction between archetypes due to linear muscle scaling.

Issues Created

High Priority (4 issues, 19-23h total)

#1155 - Add Missing Feet Rendering (S, 2-3h)

  • Foot bones (FOOT_L, FOOT_R) exist in skeletal rig but lack 3D geometry
  • Visual completeness: 93% (26/28 bones rendered)

#1157 - Implement Clothing System (L, 12-16h)

  • All fighters render as nude skeletal models
  • Need Korean martial arts-inspired attire per archetype (dobok, tactical gear, bodysuit, etc.)
  • 5 distinct clothing sets with cyberpunk aesthetic integration

#1158 - Fix Muscle/Fat Scaling for Skinny Archetypes (S, 2-3h)

  • Hacker (28kg muscle) and Amsalja (30kg muscle) appear too bulky
  • Current: Linear 2.5x amplification inflates small values
  • Solution: Exponential curve (exponent 1.8) → Hacker 0.67x, Amsalja 0.75x scale

#1159 - Enhance Muscle/Fat Scaling for Large Archetype (S, 2-3h)

  • Jojik (48kg muscle, 105kg total) only 37% larger than baseline
  • Need: 84% larger muscles, visible fat layer (0.72 opacity), wider shoulders
  • Solution: Same exponential curve → Jojik 1.84x scale

Medium Priority (1 issue, 4-6h)

#1160 - Add Body Shape Variations (M, 4-6h)

  • Shoulder width (43-54cm), limb lengths (73-84cm arms, 92-102cm legs) defined but not fully utilized
  • Existing createScaledHumanoidRig() system ready to leverage
  • Verify usage and enhance scaling amplification for visual distinction

Technical Approach

Current muscle scaling (linear):

// BoneAttachedMuscles.tsx - BEFORE
const MUSCLE_AMPLIFICATION_FACTOR = 2.5;
const scaleFactor = (muscleMass / referenceMass) * MUSCLE_AMPLIFICATION_FACTOR;
// Result: Insufficient differentiation at extremes

Proposed muscle scaling (exponential):

// AFTER
const MUSCLE_AMPLIFICATION_BASE = 2.2;
const MUSCLE_AMPLIFICATION_EXPONENT = 1.8;

const massRatio = muscleMass / referenceMass;
const deviation = massRatio - 1.0;
const exponentialDeviation = Math.sign(deviation) * Math.pow(Math.abs(deviation), MUSCLE_AMPLIFICATION_EXPONENT);

return Math.max(0.5, 1.0 + exponentialDeviation * MUSCLE_AMPLIFICATION_BASE);
// Result: Dramatic differences at extremes (Hacker 0.67x, Jojik 1.84x)

Metrics

  • Current visual completeness: 93% (missing feet)
  • Archetype distinction: Muscle/fat only (need clothing + proportions)
  • Muscle scaling: Linear 2.5x → Exponential 1.8 exponent
  • Body proportions: Defined but underutilized (shoulder width, limb lengths)

All issues include measured metrics, implementation guidance, test requirements, and agent recommendations (@hack23-code-quality-engineer for most).

Original prompt

Create 5 github issues to improve look and feel and more realistic fighters (body) in
src/components/shared/three/models
and
src/components/shared/three/anatomy

Missing feet, missing clothes, muscle/fat does not look based on physical attributes to small on skinny archetypes and to massive on large archetypes.

do not assign to copilot, will assign to .github/agents/game-developer.md later

Custom agent used: hack23-blacktrigram-taskagent
Black Trigram product specialist creating GitHub issues for Korean-themed RPG game, optimizing game mechanics, UI/UX, and ensuring ISMS alignment


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Improve look and feel of fighter models Create 5 GitHub issues for fighter body model improvements Jan 11, 2026
Copilot AI requested a review from pethers January 11, 2026 02:36
@pethers pethers marked this pull request as ready for review January 12, 2026 22:47
@pethers pethers merged commit 64f1793 into main Jan 13, 2026
3 checks passed
@pethers pethers deleted the copilot/improve-fighter-look-and-feel branch January 13, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants