Read article SEO directly from executive-brief.md; make article.md body-only by Copilot · Pull Request #2725 · Hack23/riksdagsmonitor

Copilot · 2026-05-24T16:30:30Z

Read article SEO directly from executive-brief.md; make article.md body-only
Fix no-misleading-character-class ESLint errors in scripts/check-headline-quality.ts (add u flag to boilerplate-prefix regexes containing emoji surrogate pairs)
Fix typecheck failures (Dirent<NonSharedBuffer> / errorLineNumber: number | null / unused MermaidBlock import) in scripts/fix-mermaid-diagrams.ts, scripts/validate-mermaid-diagrams.ts, and scripts/validators/mermaid-diagrams/index.ts so the PR-only TypeScript & JavaScript Testing workflow type-checks cleanly under @types/node 25.9
npm run lint clean (only the pre-existing unrelated build-csv-contracts-fixture.ts warning remains)
npx tsc -p tsconfig.scripts.json --noEmit clean
npm test passes (6091 tests, exit 0)

…iling-token strip Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-24T16:32:17Z

🏷️ Automatic Labeling Summary

This PR has been automatically labeled based on the files changed and PR metadata.

Applied Labels: documentation,size-xs

Label Categories

🗳️ Content: news, dashboard, visualization, intelligence
💻 Technology: html-css, javascript, workflow, security
📊 Data: cia-data, riksdag-data, data-pipeline, schema
🌍 I18n: i18n, translation, rtl
🔒 ISMS: isms, iso-27001, nist-csf, cis-controls
🏗️ Infrastructure: ci-cd, deployment, performance, monitoring
🔄 Quality: testing, accessibility, documentation, refactor
🤖 AI: agent, skill, agentic-workflow

For more information, see .github/labeler.yml.

github-actions · 2026-05-24T16:32:36Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

…flow flag Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-24T16:43:27Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

github-actions · 2026-05-24T16:45:15Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-24T16:57:09Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-24T17:44:45Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-24T19:14:03Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-24T20:24:16Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

…cle.md frontmatter Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-24T21:11:24Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

github-actions · 2026-05-24T21:19:47Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

pethers · 2026-05-24T21:20:48Z

@copilot analyse and improve code quality and test failing checks
Quality Checks / typescript-lint (pull_request)
Quality Checks / typescript-lint (pull_request)Failing after 2m
TypeScript & JavaScript Testing / Node.js Nightly Compat (pull_request)
TypeScript & JavaScript Testing / Node.js Nightly Compat (pull_request)Failing after 2m
TypeScript & JavaScript Testing / Unit Tests (Vitest) (pull_request)
TypeScript & JavaScript Testing / Unit Tests (Vitest) (pull_request)Failing after 3m

…n mermaid script types with @types/node 25.9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot · 2026-05-24T21:51:15Z

@copilot analyse and improve code quality and test failing checks
[Quality Checks / typescript-lint (pull_request)](https://github.com/Hack23/riksdagsmonitor/actions/runs/26372987026...

Root causes identified and fixed in the latest commit:

Quality Checks / typescript-lint — scripts/check-headline-quality.ts (added in this PR) had 8 no-misleading-character-class errors because the boilerplate-prefix regexes embed emoji (📋📰🎯⚡🧭) inside a character class without the u flag. Added u to both regexes.
Unit Tests (Vitest) / Node.js Nightly Compat — both jobs were skipping the Vitest step because tsc -p tsconfig.scripts.json --noEmit (step 8) failed. The errors live in mermaid scripts that were merged in from main but only trip under the PR-triggered Node 26 + @types/node 25.9 combo (main's push-trigger workflow doesn't run this typecheck, so they slipped in unnoticed):
- Dirent<NonSharedBuffer> vs Dirent<string> from readdirSync({withFileTypes:true}) → explicitly typed entries as Dirent[] in scripts/fix-mermaid-diagrams.ts + scripts/validate-mermaid-diagrams.ts.
- Local errorLineNumber?: number widened to number | null to match MermaidFileViolation.
- Removed the unused MermaidBlock import in scripts/validators/mermaid-diagrams/index.ts (noUnusedLocals).

Verified locally:

npm run lint → 0 errors (only the pre-existing unrelated build-csv-contracts-fixture.ts no-console directive warning remains)
npx tsc -p tsconfig.scripts.json --noEmit → clean
npm test → all 6091 tests pass, exit 0

github-actions · 2026-05-24T21:54:21Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

fix(seo): make brandTitle per-language SERP-budget aware + harden tra…

3a4352b

…iling-token strip Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot AI assigned Copilot and pethers May 24, 2026

Copilot AI changed the title ~~fix(seo): make brandTitle per-language SERP-budget aware + harden trailing-token strip~~ fix(seo): make brandTitle per-language SERP-budget aware May 24, 2026

Copilot finished work on behalf of pethers May 24, 2026 16:31

Copilot created this pull request from a session on behalf of pethers May 24, 2026 16:31 View session

Copilot AI requested a review from pethers May 24, 2026 16:31

github-actions Bot added documentation Documentation updates size-xs Extra small change (< 10 lines) labels May 24, 2026

Copilot started work on behalf of pethers May 24, 2026 16:32 View session

Phase 2 item 1: strip admin bylines before brief-entity extraction

ffb59b9

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions Bot added html-css HTML/CSS changes translation Translation updates rtl RTL language support (Arabic, Hebrew) testing Test coverage news News articles and content generation labels May 24, 2026

Phase 2 item 2: add --strict exit gate to test-article-headers + work…

e34cead

…flow flag Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions Bot added workflow GitHub Actions workflows ci-cd CI/CD pipeline changes labels May 24, 2026

Phase 2 item 3: add content-side headline-quality validator

34df9ad

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot AI changed the title ~~fix(seo): make brandTitle per-language SERP-budget aware~~ Phase 2: harden brief keywords, strict header CI gate, content-side headline-quality validator May 24, 2026

Copilot finished work on behalf of pethers May 24, 2026 16:55

Copilot started work on behalf of pethers May 24, 2026 17:04 View session

Start phase 3 headline cleanup

d13b1c6

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot started work on behalf of pethers May 24, 2026 18:19 View session

fix(seo): align truncation/head-metadata tests with date-prefix contract

5e001f3

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot AI changed the title ~~Start phase 3 with scoped headline QA in article generation~~ Localized newsroom date prefix/dateline for SEO uniqueness across 14 languages May 24, 2026

Copilot finished work on behalf of pethers May 24, 2026 19:12

Copilot started work on behalf of pethers May 24, 2026 19:26 View session

Copilot finished work on behalf of pethers May 24, 2026 19:40

Copilot started work on behalf of pethers May 24, 2026 19:48 View session

Apply remaining changes

10ebd38

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot AI changed the title ~~Localized newsroom date prefix/dateline for SEO uniqueness across 14 languages~~ Drop date prefix from SEO title/description; source SEO from executive briefs May 24, 2026

Copilot finished work on behalf of pethers May 24, 2026 20:22

Copilot started work on behalf of pethers May 24, 2026 20:26 View session

Wire renderer to read SEO from executive-brief.md; drop SEO from arti…

eaeb9b9

…cle.md frontmatter Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot AI changed the title ~~Drop date prefix from SEO title/description; source SEO from executive briefs~~ Read article SEO directly from executive-brief.md; make article.md body-only May 24, 2026

Copilot finished work on behalf of pethers May 24, 2026 21:10

Merge branch 'main' into copilot/improve-news-titles-descriptions

35ffcd4

Copilot started work on behalf of pethers May 24, 2026 21:20 View session

fix(ci): unblock PR CI — add 'u' flag to surrogate-pair regexes; alig…

55060d0

…n mermaid script types with @types/node 25.9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot finished work on behalf of pethers May 24, 2026 21:51

pethers marked this pull request as ready for review May 24, 2026 22:00

Copilot AI review requested due to automatic review settings May 24, 2026 22:00

Copilot AI reviewed May 24, 2026

pethers merged commit fb25411 into main May 24, 2026
21 of 22 checks passed

pethers deleted the copilot/improve-news-titles-descriptions branch May 24, 2026 22:10

Uh oh!

Uh oh!

Conversation

Copilot AI commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 24, 2026

🏷️ Automatic Labeling Summary

Label Categories

Uh oh!

github-actions Bot commented May 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions Bot commented May 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions Bot commented May 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions Bot commented May 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions Bot commented May 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions Bot commented May 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions Bot commented May 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions Bot commented May 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions Bot commented May 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

pethers commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026

Uh oh!

github-actions Bot commented May 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 24, 2026 •

edited

Loading