This repository was archived by the owner on May 22, 2020. It is now read-only.
RUN-4357 better child process handling #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyn07m3
requested review from
MichaelMCoates,
StevenEBarbaro,
datamadic,
patpao,
pbaize,
rdepena and
wenjunche
rdepena
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some weirdness happening with the runtime when it's launched from Node and its standard out is not ignored or handled. This fixes it. We had something similar with our test runner and we implemented the same fix and it's been working great for years.
Runtime's standard out attaches to RVM's standard out and we are getting both RVM's and Runtime's standard out messages (✅This is true and confirmed).
If we don't ignore all these messages or handle them to clear the buffer, the buffer get backed up and slows everything down. The default buffer size is 200KB (documented for
.execand other Node APIs, but not for.spawn, that we use here, and I seem to not be able to change the size to verify if that would solve the issue as well), it's mentioned here.