Skip to content

Conversation

@jfthuong
Copy link

Summary of changes:

  • Upgraded depencies on Python to support both Python 2.7 and Python 3

Regressions to look for:

  • None

Completed checkin tasks:

  • Updated changelog/public/latest.json.

@jfthuong
Copy link
Author

Python2 is still needed for the current version of node-gyp listed in package.json.

Copy link

@andrewnc andrewnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes all look good to me! Have you been able to test pushing with them?

# Install git
choco install git python2 -y
choco install git python -y

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should include a winget json for most windows environments, not everyone has choco, for linux and mac with homebrew you can include a brewfile, hate having to use requirements that don't match up in a readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants