autobonus doesn't work on item combo

[memoryss1]

[bangzeed]

about this

http://herc.ws/board/topic/12095-item-combo-and-getrefine-bug/

[memoryss1]

getrefine problem you can simply change it to getequiprefinerycnt

[bangzeed]

thank you bro.

[memoryss1]

@MishimaHaruna This is not a question@@

[Playtester]

Yeah this is actually a bug. Autobonus assigning the equipment position to the bonus so it can remember when to remove it. It doesn't work with the new combo db format. You would need to create one identifier for any of the 800+ possible equip position combinations and then assign the autobonus to that to implement it properly, but so much work. X_X

I did a temporary solution on rAthena, not sure if Herc has that...

rathena/rathena@b6b6b13 That one.

[iRagno]

The issue persist on actual repo. Tested on 9fba7e8

How to reproduce:

Put this script into any combo:

autobonus "{ bonus bStr, 10; }",1000,5000,BF_WEAPON,"{ specialeffect2 EF_POTION_BERSERK; }";

That script brings 100% chance of set Str+10 for 5 seconds with specialeffect EF_POTION_BERSERK. However, when contained into item_combo_db this script doesnt work. Then, put the same script on any item on item_db.conf and autobonus will triger.

There are several items damaged because of this. I have fixed it locally by bringing those autobonuses into item_db.conf, until item_combdo_db.txt gets fixed.

@HerculesWS/developers

[iRagno]

@Ridley8819, you forgot to reopen this.