warpparty() and warpguild() are checking for nowarp mapflag

[bWolfie]

Issue Prelude

• I have not modified the source prior to reproducing this issue.
• I am using the latest version of Hercules.
• I am aware that this report will be closed or deleted if it becomes obvious that I am stating the false.

Description

BUILDIN(warpparty) and BUILDIN(warpguild) are checking for the nowarp and noreturn mapflags.

Current Behavior

These script commands cannot be used to warp guilds/parties around on nowarp mapflags.

Expected Behavior

Just like the regular warp() command, you should be able to warp regardless.

Branch(es):

• master
• other

[Helianthella]

I believe it would be a better idea to just add an extra parameter to warp() so it can take a GID, and then deprecate warpparty() and warpguild() since getunits() makes them obsolete. It will also help avoid having yet more warp commands when we merge the Clan system

[psychonaut04]

I did something just to test.

stable...psychonaut04:patch-2

"Deprecated" warpparty and warpguild, just with a warning(it still works).
Warp using switch, a char change it to warpguild(can use getunits i guess, but check gid, i'm not sure if it's better), can change it somehow still to add more.

Just a code testing(i did for fun only). If that's something acceptable i can improve or pull it.